update is_proposer definition #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please move the issue from google doc to gh issue |
xiaoxichen
reviewed
Dec 3, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
===========================================
+ Coverage 56.51% 66.63% +10.12%
===========================================
Files 108 109 +1
Lines 10300 10770 +470
Branches 1402 1470 +68
===========================================
+ Hits 5821 7177 +1356
+ Misses 3894 2885 -1009
- Partials 585 708 +123 ☔ View full report in Codecov by Sentry. |
Besroy
force-pushed
the
update_proposer
branch
from
e1e318a to
bc63b8b
Compare
Besroy
changed the title
Besroy
changed the title
Besroy
force-pushed
the
update_proposer
branch
2 times, most recently
from
f4b6ae5 to
76994de
Compare
Besroy
force-pushed
the
update_proposer
branch
2 times, most recently
from
94bf6b9 to
0fa3b66
Compare
Besroy
force-pushed
the
update_proposer
branch
from
0fa3b66 to
3aba157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define is_proposer by comparing m_raft_server_id with rkey.server_id